There’s really no bad time to visit China, as the country is so large and diverse that different regions are at their best at different times of year. For most destinations, April to June and September to November offer pleasant weather for sightseeing.
There are exceptions, though. For example, Harbin and Sanya are especially popular in winter, while Guizhou, Yunnan, and Inner Mongolia are great choices for escaping the summer heat.